[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] Put dependency files in proper subdir
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH] Put dependency files in proper subdir |
Date: |
Sat, 15 May 2010 13:13:39 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Jan Kiszka wrote:
> From: Jan Kiszka <address@hidden>
>
> This seems to resolve subtle breakages of our build system:
>
> Dependency files generated for targets like 'dir/foo.o' were saved as
> 'foo.d'. Now, if there was also a target 'foo.o', one of the dependency
> file was overwritten. Concrete example: libhw*/macio.o vs.
> libhw*/ide/macio.o. And this often left a segfaulting build result
> behind when changing the "wrong" data structures".
Actually, most lethal was qdev.o vs. ide/qdev.o.
Jan
>
> Fix it by generating proper 'dir/foo.d'.
>
> Signed-off-by: Jan Kiszka <address@hidden>
> ---
> rules.mak | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/rules.mak b/rules.mak
> index 7e10432..c843a13 100644
> --- a/rules.mak
> +++ b/rules.mak
> @@ -12,7 +12,7 @@ MAKEFLAGS += -rR
> %.mak:
>
> # Flags for dependency generation
> -QEMU_DGFLAGS += -MMD -MP -MT $@
> +QEMU_DGFLAGS += -MMD -MP -MT $@ -MF $(*D)/$(*F).d
>
> %.o: %.c
> $(call quiet-command,$(CC) $(QEMU_CFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) -c
> -o $@ $<," CC $(TARGET_DIR)$@")
signature.asc
Description: OpenPGP digital signature