|
From: | Avi Kivity |
Subject: | [Qemu-devel] Re: [PATCH 3/8] Add QBuffer |
Date: | Sun, 16 May 2010 12:50:33 +0300 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Thunderbird/3.0.4 |
On 05/16/2010 12:37 PM, Paolo Bonzini wrote:
On 05/15/2010 07:31 PM, Avi Kivity wrote:On 05/15/2010 11:59 AM, Jan Kiszka wrote:Is this __class__ stuff documented anywhere?Not yet. Also, we should clarify the proposed private extension section that only "__some_key" is reserved for downstream, not '__some_other_key__' (i.e. downstream names must not end with '__').Why use such weird names at all? What's wrong with 'class'?That it conflicts with e.g. PCI classes?
Won't the context tell it apart? When you expect a pci function, 'class': 'video' means one thing, when you read a buffer it means another.
The only reason to use a special name is if it's a protocol level feature that can happen in all contexts. But in that case we're better off with a schema, we don't want to push class descriptors everywhere.
-- error compiling committee.c: too many arguments to function
[Prev in Thread] | Current Thread | [Next in Thread] |