qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 7/7] trace: Trace virtqueue operations


From: Avi Kivity
Subject: [Qemu-devel] Re: [PATCH 7/7] trace: Trace virtqueue operations
Date: Tue, 25 May 2010 16:52:34 +0300
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Thunderbird/3.0.4

On 05/25/2010 04:27 PM, Stefan Hajnoczi wrote:
On Tue, May 25, 2010 at 1:04 PM, Avi Kivity<address@hidden>  wrote:
Those %ps are more or less useless.  We need better ways of identifying
them.
You're right, the vq pointer is useless in isolation.  We don't know
which virtio device or which virtqueue number.

With the full context of a trace it would be possible to correlate the
vq pointer if we had trace events for vdev and vq setup.

Adding custom formatters is could be tricky since the format string is
passed only to tracing backends that use it, like UST.  And UST uses
its own sprintf implementation which we don't have direct control
over.

Hm. Perhaps we can convert %{type} to %p for backends which don't support it, and to whatever format they do support for those that do.

--
error compiling committee.c: too many arguments to function




reply via email to

[Prev in Thread] Current Thread [Next in Thread]