|
From: | Gerd Hoffmann |
Subject: | [Qemu-devel] Re: [PATCH v2] qdev-properties: Fix (u)intXX parsers |
Date: | Wed, 26 May 2010 14:38:05 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc12 Thunderbird/3.0.4 |
On 05/26/10 13:27, Kevin Wolf wrote:
scanf calls must not use PRI constants, they have probably the wrong size and corrupt memory. We could replace them by SCN ones, but strtol is simpler than scanf here anyway. While at it, also fix the parsers to reject garbage after the number ("4096xyz" was accepted before).
Looks good to me. Acked-by: Gerd Hoffmann <address@hidden> cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |