[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] block.h: Make BDRV_SECTOR_SIZE 64 bit safe
|
From: |
Jes Sorensen |
|
Subject: |
[Qemu-devel] Re: [PATCH] block.h: Make BDRV_SECTOR_SIZE 64 bit safe |
|
Date: |
Thu, 27 May 2010 17:44:03 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc12 Lightning/1.0b2pre Thunderbird/3.0.4 |
On 05/27/10 17:38, Paolo Bonzini wrote:
> On 05/27/2010 04:27 PM, Kevin Wolf wrote:
>> Am 27.05.2010 15:46, schrieb address@hidden:
>>> From: Jes Sorensen<address@hidden>
>>>
>>> C defaults to int, so make definition of BDRV_SECTOR_SIZE 64 bit
>>> safe as it and BDRV_SECTOR_MASK may be used against 64 bit addresses.
>>>
>>> Signed-off-by: Jes Sorensen<address@hidden>
>>
>> Thanks, applied to the block branch.
>
> Candidate for stable too?
It should be safe to apply, but I didn't find any current users where
the mask was applied in a way where it was causing problems. Not sure if
you want the noise, or apply it as better safe than sorry?
Cheers,
Jes