[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 04/17] qdev: Give qtree names precedence over
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v3 04/17] qdev: Give qtree names precedence over user-assigned IDs |
Date: |
Mon, 31 May 2010 13:12:40 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Gerd Hoffmann <address@hidden> writes:
>> pci_add nic -net use either the ID or option "name" of qemu_net_opts.
>> And there's our hole. Reproducible with "-net user -net nic,id=foo
>> -device lsi,id=foo".
>
> Oh. Well. Yes, better plug that.
>
>> @@ -242,6 +243,10 @@ DeviceState *qdev_device_add(QemuOpts *opts)
>> qdev = qdev_create_from_info(bus, info);
>> id = qemu_opts_id(opts);
>> if (id) {
>> + if (qdev_find_recursive(main_system_bus, id)) {
>> + qerror_report(QERR_DUPLICATE_ID, id, "device");
>> + return NULL;
>> + }
>> qdev->id = id;
>> }
>> if (qemu_opt_foreach(opts, set_property, qdev, 1) != 0) {
>
> Looks good..
>
> Acked-by: Gerd Hoffmann <address@hidden>
I'll repost it as a well-formed patch. While there, I'll outlaw "/".
What about requiring IDs to start with a letter? Just in case we ever
want to add alias names that must not clash with user-specified IDs.
- [Qemu-devel] Re: [PATCH v3 06/17] qdev: Allow device specification by qtree path for device_del, (continued)
- [Qemu-devel] Re: [PATCH v3 06/17] qdev: Allow device specification by qtree path for device_del, Jan Kiszka, 2010/05/28
- Re: [Qemu-devel] Re: [PATCH v3 06/17] qdev: Allow device specification by qtree path for device_del, Markus Armbruster, 2010/05/28
- Re: [Qemu-devel] Re: [PATCH v3 06/17] qdev: Allow device specification by qtree path for device_del, Jan Kiszka, 2010/05/28
- Re: [Qemu-devel] Re: [PATCH v3 06/17] qdev: Allow device specification by qtree path for device_del, Markus Armbruster, 2010/05/29
- Re: [Qemu-devel] Re: [PATCH v3 06/17] qdev: Allow device specification by qtree path for device_del, Jan Kiszka, 2010/05/29
[Qemu-devel] [PATCH v3 04/17] qdev: Give qtree names precedence over user-assigned IDs, Jan Kiszka, 2010/05/23
- Re: [Qemu-devel] [PATCH v3 04/17] qdev: Give qtree names precedence over user-assigned IDs, Markus Armbruster, 2010/05/29
- Re: [Qemu-devel] [PATCH v3 04/17] qdev: Give qtree names precedence over user-assigned IDs, Avi Kivity, 2010/05/30
- Re: [Qemu-devel] [PATCH v3 04/17] qdev: Give qtree names precedence over user-assigned IDs, Markus Armbruster, 2010/05/31
- Re: [Qemu-devel] [PATCH v3 04/17] qdev: Give qtree names precedence over user-assigned IDs, Gerd Hoffmann, 2010/05/31
- Re: [Qemu-devel] [PATCH v3 04/17] qdev: Give qtree names precedence over user-assigned IDs,
Markus Armbruster <=
- [Qemu-devel] [PATCH] qdev: Reject duplicate and anti-social device IDs, Markus Armbruster, 2010/05/31
- [Qemu-devel] Re: [PATCH] qdev: Reject duplicate and anti-social device IDs, Gerd Hoffmann, 2010/05/31
[Qemu-devel] [PATCH v3 05/17] qdev: Convert device and bus lists to QTAILQ, Jan Kiszka, 2010/05/23
[Qemu-devel] [PATCH v3 01/17] Add dependency of JSON unit tests on config-host.h, Jan Kiszka, 2010/05/23
[Qemu-devel] [PATCH v3 11/17] Add QBuffer, Jan Kiszka, 2010/05/23
[Qemu-devel] [PATCH v3 07/17] qdev: Push QMP mode checks into qbus_list_bus/dev, Jan Kiszka, 2010/05/23
[Qemu-devel] [PATCH v3 08/17] monitor: Add completion for qdev paths, Jan Kiszka, 2010/05/23
[Qemu-devel] [PATCH v3 09/17] Add base64 encoder/decoder, Jan Kiszka, 2010/05/23
[Qemu-devel] [PATCH v3 15/17] QMP: Teach basic capability negotiation to python example, Jan Kiszka, 2010/05/23
[Qemu-devel] [PATCH v3 13/17] monitor: Allow to exclude commands from QMP, Jan Kiszka, 2010/05/23