[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 25/35] tcg-s390: Use the MULTIPLY IMMEDIATE instruct
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PATCH 25/35] tcg-s390: Use the MULTIPLY IMMEDIATE instructions. |
Date: |
Fri, 4 Jun 2010 12:14:33 -0700 |
Signed-off-by: Richard Henderson <address@hidden>
---
tcg/s390/tcg-target.c | 43 +++++++++++++++++++++++++++++++++++++++----
1 files changed, 39 insertions(+), 4 deletions(-)
diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c
index 5446591..f1e00e9 100644
--- a/tcg/s390/tcg-target.c
+++ b/tcg/s390/tcg-target.c
@@ -36,6 +36,7 @@
#define TCG_CT_CONST_32 0x0100
#define TCG_CT_CONST_NEG 0x0200
#define TCG_CT_CONST_ADDI 0x0400
+#define TCG_CT_CONST_MULI 0x8000
#define TCG_CT_CONST_ANDI 0x1000
#define TCG_CT_CONST_ORI 0x2000
#define TCG_CT_CONST_XORI 0x4000
@@ -64,6 +65,8 @@ typedef enum S390Opcode {
RIL_LGFI = 0xc001,
RIL_LLIHF = 0xc00e,
RIL_LLILF = 0xc00f,
+ RIL_MSFI = 0xc201,
+ RIL_MSGFI = 0xc200,
RIL_NIHF = 0xc00a,
RIL_NILF = 0xc00b,
RIL_OIHF = 0xc00c,
@@ -83,6 +86,8 @@ typedef enum S390Opcode {
RI_LLIHL = 0xa50d,
RI_LLILH = 0xa50e,
RI_LLILL = 0xa50f,
+ RI_MGHI = 0xa70d,
+ RI_MHI = 0xa70c,
RI_NIHH = 0xa504,
RI_NIHL = 0xa505,
RI_NILH = 0xa506,
@@ -336,6 +341,10 @@ static int target_parse_constraint(TCGArgConstraint *ct,
const char **pct_str)
ct->ct &= ~TCG_CT_REG;
ct->ct |= TCG_CT_CONST_ADDI;
break;
+ case 'K':
+ ct->ct &= ~TCG_CT_REG;
+ ct->ct |= TCG_CT_CONST_MULI;
+ break;
case 'A':
ct->ct &= ~TCG_CT_REG;
ct->ct |= TCG_CT_CONST_ANDI;
@@ -497,6 +506,16 @@ static int tcg_target_const_match(tcg_target_long val,
} else {
return val == (int16_t)val;
}
+ } else if (ct & TCG_CT_CONST_MULI) {
+ /* Immediates that may be used with multiply. If we have the
+ general-instruction-extensions, then we have MULTIPLY SINGLE
+ IMMEDIATE with a signed 32-bit, otherwise we have only
+ MULTIPLY HALFWORD IMMEDIATE, with a signed 16-bit. */
+ if (facilities & FACILITY_GEN_INST_EXT) {
+ return val == (int32_t)val;
+ } else {
+ return val == (int16_t)val;
+ }
} else if (ct & TCG_CT_CONST_ANDI) {
return tcg_match_andi(ct, val);
} else if (ct & TCG_CT_CONST_ORI) {
@@ -1511,10 +1530,26 @@ static inline void tcg_out_op(TCGContext *s, TCGOpcode
opc,
break;
case INDEX_op_mul_i32:
- tcg_out_insn(s, RRE, MSR, args[0], args[2]);
+ if (const_args[2]) {
+ if ((int32_t)args[2] == (int16_t)args[2]) {
+ tcg_out_insn(s, RI, MHI, args[0], args[2]);
+ } else {
+ tcg_out_insn(s, RIL, MSFI, args[0], args[2]);
+ }
+ } else {
+ tcg_out_insn(s, RRE, MSR, args[0], args[2]);
+ }
break;
case INDEX_op_mul_i64:
- tcg_out_insn(s, RRE, MSGR, args[0], args[2]);
+ if (const_args[2]) {
+ if (args[2] == (int16_t)args[2]) {
+ tcg_out_insn(s, RI, MGHI, args[0], args[2]);
+ } else {
+ tcg_out_insn(s, RIL, MSGFI, args[0], args[2]);
+ }
+ } else {
+ tcg_out_insn(s, RRE, MSGR, args[0], args[2]);
+ }
break;
case INDEX_op_div2_i32:
@@ -1755,7 +1790,7 @@ static const TCGTargetOpDef s390_op_defs[] = {
{ INDEX_op_add_i32, { "r", "0", "rWI" } },
{ INDEX_op_sub_i32, { "r", "0", "rWNI" } },
- { INDEX_op_mul_i32, { "r", "0", "r" } },
+ { INDEX_op_mul_i32, { "r", "0", "rK" } },
{ INDEX_op_div2_i32, { "b", "a", "0", "1", "r" } },
{ INDEX_op_divu2_i32, { "b", "a", "0", "1", "r" } },
@@ -1817,7 +1852,7 @@ static const TCGTargetOpDef s390_op_defs[] = {
{ INDEX_op_add_i64, { "r", "0", "rI" } },
{ INDEX_op_sub_i64, { "r", "0", "rNI" } },
- { INDEX_op_mul_i64, { "r", "0", "r" } },
+ { INDEX_op_mul_i64, { "r", "0", "rK" } },
{ INDEX_op_div2_i64, { "b", "a", "0", "1", "r" } },
{ INDEX_op_divu2_i64, { "b", "a", "0", "1", "r" } },
--
1.7.0.1
- [Qemu-devel] [PATCH 18/35] tcg-s390: Implement bswap operations., (continued)
- [Qemu-devel] [PATCH 18/35] tcg-s390: Implement bswap operations., Richard Henderson, 2010/06/04
- [Qemu-devel] [PATCH 19/35] tcg-s390: Implement rotates., Richard Henderson, 2010/06/04
- [Qemu-devel] [PATCH 20/35] tcg-s390: Use LOAD COMPLIMENT for negate., Richard Henderson, 2010/06/04
- [Qemu-devel] [PATCH 21/35] tcg-s390: Use the ADD IMMEDIATE instructions., Richard Henderson, 2010/06/04
- [Qemu-devel] [PATCH 22/35] tcg-s390: Use the AND IMMEDIATE instructions., Richard Henderson, 2010/06/04
- [Qemu-devel] [PATCH 23/35] tcg-s390: Use the OR IMMEDIATE instructions., Richard Henderson, 2010/06/04
- [Qemu-devel] [PATCH 24/35] tcg-s390: Use the XOR IMMEDIATE instructions., Richard Henderson, 2010/06/04
- [Qemu-devel] [PATCH 25/35] tcg-s390: Use the MULTIPLY IMMEDIATE instructions.,
Richard Henderson <=
- [Qemu-devel] [PATCH 26/35] tcg-s390: Tidy goto_tb., Richard Henderson, 2010/06/04
- [Qemu-devel] [PATCH 27/35] tcg-s390: Rearrange qemu_ld/st to avoid register copy., Richard Henderson, 2010/06/04
- [Qemu-devel] [PATCH 28/35] tcg-s390: Tidy tcg_prepare_qemu_ldst., Richard Henderson, 2010/06/04
- [Qemu-devel] [PATCH 29/35] tcg-s390: Tidy user qemu_ld/st., Richard Henderson, 2010/06/04
- [Qemu-devel] [PATCH 30/35] tcg-s390: Implement GUEST_BASE., Richard Henderson, 2010/06/04
- [Qemu-devel] [PATCH 31/35] tcg-s390: Use 16-bit branches for forward jumps., Richard Henderson, 2010/06/04
- [Qemu-devel] [PATCH 33/35] tcg-s390: Use the COMPARE IMMEDIATE instrucions for compares., Richard Henderson, 2010/06/04
- [Qemu-devel] [PATCH 34/35] tcg-s390: Use COMPARE AND BRANCH instructions., Richard Henderson, 2010/06/04
- [Qemu-devel] [PATCH 32/35] tcg-s390: Use the LOAD AND TEST instruction for compares., Richard Henderson, 2010/06/04
- [Qemu-devel] [PATCH 35/35] tcg-s390: Enable compile in 32-bit mode., Richard Henderson, 2010/06/04