Re: [Qemu-devel] [PATCH] monitor: allow device to be ejected if no disk is inserted

[Kevin Wolf]

Am 07.06.2010 14:43, schrieb Eduardo Habkost:
> On Mon, Jun 07, 2010 at 02:19:28PM +0200, Markus Armbruster wrote:
>> Kevin Wolf <address@hidden> writes:
>>> Am 02.06.2010 00:12, schrieb Eduardo Habkost:
>>>> The first eject command didn't work because the is_inserted() check
>>>> failed.
>>>
>>> But does it really make a difference? The guest should not see a medium
>>> before and it should not see one afterwards.
> 
> It does

How that? Even if the host device is still connected, but no there's no
medium in it, the guest shouldn't see a medium (I mean, which medium
should it see if there is none?)

> as the whole purpose of the "eject" command is to disconnect
> the block device from the host backing file.
> 
> Awful naming, I agree, but that's the expected semantics of the command.

If it's just meant to say "disconnect the image" it's a really bad name.
Luiz, can we please get rid of it before QMP becomes stable?

> If we want to solve the naming confusion, this could be implemented as a
> special case of the "change" command instead, and then the "eject"
> command could be deprecated.

Sounds much better, though it was suggested to deprecate "change"
itself, too. ;-)

Kevin