qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 00/16] clean up vl.c code


From: Jes Sorensen
Subject: Re: [Qemu-devel] [PATCH 00/16] clean up vl.c code
Date: Wed, 09 Jun 2010 10:14:19 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc12 Lightning/1.0b2pre Thunderbird/3.0.4

On 06/09/10 09:07, Markus Armbruster wrote:
> Jes Sorensen <address@hidden> writes:
>> On 06/04/10 13:54, Markus Armbruster wrote:
>> If there is strong feeling we should do it this way instead, I can
>> change the code to do it this way instead. I am not married to the
>> current approach, I just find it the lesser evil.
> 
> I'm making suggestions, not demands.  If you still prefer your way after
> considering my suggestions, go with it.
> 
> For what it's worth, pushing OS-dependent bits out of the option parsing
> allows for:
> 
>     qemu: --frobnicate: Can't frobnicate under Windows
> 
> instead of
> 
>     qemu: --frobnicate: invalid option

That is true, on the other hand I think it would be cleaner to not
advertise options on an OS where it is not supported. Ideally I would
like them to not show up in qemu --help at all.

Cheers,
Jes



reply via email to

[Prev in Thread] Current Thread [Next in Thread]