[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific fi
From: |
Frank Arnold |
Subject: |
Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files |
Date: |
Fri, 25 Jun 2010 18:41:22 +0200 |
On Thu, 2010-06-10 at 05:42 -0400, address@hidden wrote:
> diff --git a/os-posix.c b/os-posix.c
> index 6417d16..1672e06 100644
> --- a/os-posix.c
> +++ b/os-posix.c
> @@ -160,6 +162,9 @@ void os_parse_cmd_args(int index, const char *optarg)
> case QEMU_OPTION_chroot:
> chroot_dir = optarg;
> break;
> + case QEMU_OPTION_daemonize:
> + daemonize = 1;
> + break;
> }
> return;
> }
This move broke the -daemonize option for us. We are using the qemu-kvm
tree.
The issue is that the QEMU_OPTION_* enumeration between vl.c and
os-posix.c is out of sync. In our case MAP_POPULATE is defined in vl.c
but is not in os-posix.c. This excludes the option -mem-prealloc in
os-posix.c, see qemu-options.def for the ifdef statement. All subsequent
options are off by one in comparison to vl.c.
Just including sys/mman.h in os-posix.c fixes the issue for me. But I'm
not sure if there is a more generic fix to that problem.
--
Frank Arnold
System Design Technician, Software Test
AMD Operating System Research Center
Dresden, Germany
Tel: +49 351 448 356702
Legal Information:
Advanced Micro Devices GmbH
Einsteinring 24
85609 Dornach b. München
Geschäftsführer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis München
Registergericht München, HRB Nr. 43632
- [Qemu-devel] [PATCH 07/17] Rename os_setup_signal_handling() to os_setup_early_signal_handling(), (continued)
- [Qemu-devel] [PATCH 07/17] Rename os_setup_signal_handling() to os_setup_early_signal_handling(), Jes . Sorensen, 2010/06/10
- [Qemu-devel] [PATCH 02/17] Create qemu-os-win32.h and move WIN32 specific declarations there, Jes . Sorensen, 2010/06/10
- [Qemu-devel] [PATCH 08/17] Move main signal handler setup to os specificfiles., Jes . Sorensen, 2010/06/10
- [Qemu-devel] [PATCH 10/17] Rename qemu-options.h to qemu-options.def, Jes . Sorensen, 2010/06/10
- [Qemu-devel] [PATCH 12/17] Move runas handling from vl.c to OS specific files., Jes . Sorensen, 2010/06/10
- [Qemu-devel] [PATCH 13/17] Move chroot handling to OS specific files., Jes . Sorensen, 2010/06/10
- [Qemu-devel] [PATCH 09/17] Move find_datadir to OS specific files., Jes . Sorensen, 2010/06/10
- [Qemu-devel] [PATCH 11/17] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c, Jes . Sorensen, 2010/06/10
- [Qemu-devel] [PATCH 15/17] Make os_change_process_uid and os_change_root os-posix.c local, Jes . Sorensen, 2010/06/10
- [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files, Jes . Sorensen, 2010/06/10
- Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files,
Frank Arnold <=
- Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files, Jes Sorensen, 2010/06/25
- Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files, Frank Arnold, 2010/06/25
- Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files, Frank Arnold, 2010/06/25
- Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files, Jes Sorensen, 2010/06/28
- Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files, Jes Sorensen, 2010/06/28
- Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files, Blue Swirl, 2010/06/28
- Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files, Jes Sorensen, 2010/06/28
- Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files, Blue Swirl, 2010/06/28
- Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files, Jes Sorensen, 2010/06/28
- [Qemu-devel] Re: [PATCH 14/17] Move daemonize handling to OS specific files, Paolo Bonzini, 2010/06/28