[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 02/12] ide: Make it explicit that ide_create_drive()
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH 02/12] ide: Make it explicit that ide_create_drive() can't fail |
Date: |
Fri, 25 Jun 2010 18:53:22 +0200 |
All callers of ide_create_drive() ignore its value. Currently
harmless, because it fails only when qdev_init() fails, which fails
only when ide_drive_initfn() fails, which never fails.
Brittle. Change it to die instead of silently ignoring failure.
Signed-off-by: Markus Armbruster <address@hidden>
---
hw/ide/qdev.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c
index 0f9f22e..127478b 100644
--- a/hw/ide/qdev.c
+++ b/hw/ide/qdev.c
@@ -84,8 +84,7 @@ IDEDevice *ide_create_drive(IDEBus *bus, int unit, DriveInfo
*drive)
dev = qdev_create(&bus->qbus, "ide-drive");
qdev_prop_set_uint32(dev, "unit", unit);
qdev_prop_set_drive(dev, "drive", drive);
- if (qdev_init(dev) < 0)
- return NULL;
+ qdev_init_nofail(dev);
return DO_UPCAST(IDEDevice, qdev, dev);
}
--
1.6.6.1
- [Qemu-devel] Re: [PATCH 09/12] savevm: Survive hot-unplug of snapshot device, (continued)
- [Qemu-devel] [PATCH 10/12] block: Fix virtual media change for if=none, Markus Armbruster, 2010/06/25
- [Qemu-devel] [PATCH 11/12] ide: Make PIIX and ISA IDE init functions return the qdev, Markus Armbruster, 2010/06/25
- [Qemu-devel] [PATCH 07/12] blockdev: drive_get_by_id() is no longer used, remove, Markus Armbruster, 2010/06/25
- [Qemu-devel] [PATCH 02/12] ide: Make it explicit that ide_create_drive() can't fail,
Markus Armbruster <=
- [Qemu-devel] [PATCH 04/12] blockdev: New drive_of_blockdev(), Markus Armbruster, 2010/06/25
- [Qemu-devel] Re: [PATCH 04/12] blockdev: New drive_of_blockdev(), Christoph Hellwig, 2010/06/25
- [Qemu-devel] Re: [PATCH 04/12] blockdev: New drive_of_blockdev(), Markus Armbruster, 2010/06/26
- [Qemu-devel] Re: [PATCH 04/12] blockdev: New drive_of_blockdev(), Christoph Hellwig, 2010/06/26
- Re: [Qemu-devel] Re: [PATCH 04/12] blockdev: New drive_of_blockdev(), Markus Armbruster, 2010/06/26
- Re: [Qemu-devel] Re: [PATCH 04/12] blockdev: New drive_of_blockdev(), Christoph Hellwig, 2010/06/27
- [Qemu-devel] Re: [PATCH 04/12] blockdev: New drive_of_blockdev(), Paolo Bonzini, 2010/06/28
- [Qemu-devel] Re: [PATCH 04/12] blockdev: New drive_of_blockdev(), Markus Armbruster, 2010/06/29