[Qemu-devel] Re: Block live migration's use of type hint

[Markus Armbruster]

Liran Schour <address@hidden> writes:

> Markus Armbruster <address@hidden> wrote on 28/06/2010 10:26:47:
>
>> From: Markus Armbruster <address@hidden>
>> To: address@hidden
>> Cc: Liran Schour/Haifa/address@hidden
>> Date: 28/06/2010 10:26
>> Subject: Block live migration's use of type hint
>>
>> Block live migration appears to migrate only block devices with type
>> hint BDRV_TYPE_HD.  Others are silently skipped:
>>
>> static void init_blk_migration_it(void *opaque, BlockDriverState *bs)
>> {
>>     Monitor *mon = opaque;
>>     BlkMigDevState *bmds;
>>     int64_t sectors;
>>
>>     if (bs->type == BDRV_TYPE_HD) {
>> [...]
>>     }
>> }
>>
>> The logic comes from commit c163b5ca, but its commit message doesn't
>> mention it.  Liran, please advise.  What are we trying to accomplish
>> here?
>>
>> Whatever it is, I suspect checking the type hint isn't the appropriate
>> way to get it.
>
> my intention was to migrate only writeable devices. Maybe there are more
> accurate ways to do that.

Okay, that looks like a job for bdrv_is_read_only().

Thanks for your quick reply!