[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] Don't reset bs->is_temporary in bdrv_open_common
From: |
Ryan Harper |
Subject: |
[Qemu-devel] [PATCH] Don't reset bs->is_temporary in bdrv_open_common |
Date: |
Mon, 28 Jun 2010 09:38:33 -0500 |
User-agent: |
Mutt/1.5.6+20040907i |
To fix https://bugs.launchpad.net/qemu/+bug/597402 where qemu fails to
call unlink() on temporary snapshots due to bs->is_temporary getting clobbered
in bdrv_open_common() after being set in bdrv_open() which calls the former.
We don't need to initialize bs->is_temporary in bdrv_open_common().
Signed-off-by: Ryan Harper <address@hidden>
---
block.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/block.c b/block.c
index e71a771..a55882e 100644
--- a/block.c
+++ b/block.c
@@ -393,7 +393,6 @@ static int bdrv_open_common(BlockDriverState *bs, const
char *filename,
bs->file = NULL;
bs->total_sectors = 0;
- bs->is_temporary = 0;
bs->encrypted = 0;
bs->valid_key = 0;
bs->open_flags = flags;
--
1.6.3.3
--
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
address@hidden
- [Qemu-devel] [PATCH] Don't reset bs->is_temporary in bdrv_open_common,
Ryan Harper <=