[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 06/23] net: delete QemuOpts when net_client_init() f
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] [PATCH 06/23] net: delete QemuOpts when net_client_init() fails. |
Date: |
Thu, 1 Jul 2010 16:21:34 -0300 |
From: Yoshiaki Tamura <address@hidden>
This fixes the following scenario using QMP.
First, put a bogus argument "foo" to "type", which results in an error.
{"execute": "netdev_add", "arguments": { "type": "foo", "id": "netdev1" } }
Then, call it again with correct argument "user".
{"execute": "netdev_add", "arguments": { "type": "user", "id": "netdev1" } }
This results in "DuplicatedId" error.
Because the first command was invalid, it should be able to reuse the
same "id", and the second command should work.
Reported-by: Luiz Capitulino <address@hidden>
Signed-off-by: Yoshiaki Tamura <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>
---
net.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/net.c b/net.c
index 90bd5a9..8ddf872 100644
--- a/net.c
+++ b/net.c
@@ -1208,6 +1208,10 @@ int do_netdev_add(Monitor *mon, const QDict *qdict,
QObject **ret_data)
}
res = net_client_init(mon, opts, 1);
+ if (res < 0) {
+ qemu_opts_del(opts);
+ }
+
return res;
}
--
1.7.2.rc0
- [Qemu-devel] [PATCH 00/23][PULL]: QMP/Monitor queue, Luiz Capitulino, 2010/07/01
- [Qemu-devel] [PATCH 01/23] monitor: Fix leakage during completion processing, Luiz Capitulino, 2010/07/01
- [Qemu-devel] [PATCH 02/23] monitor: Fix command completion vs. boolean switches, Luiz Capitulino, 2010/07/01
- [Qemu-devel] [PATCH 03/23] monitor: Establish cmd flags and convert the async tag, Luiz Capitulino, 2010/07/01
- [Qemu-devel] [PATCH 04/23] QMP: Teach basic capability negotiation to python example, Luiz Capitulino, 2010/07/01
- [Qemu-devel] [PATCH 05/23] QMP: Fix python helper /wrt long return strings, Luiz Capitulino, 2010/07/01
- [Qemu-devel] [PATCH 06/23] net: delete QemuOpts when net_client_init() fails.,
Luiz Capitulino <=
- [Qemu-devel] [PATCH 07/23] QMP: Fix error reporting in the async API, Luiz Capitulino, 2010/07/01
- [Qemu-devel] [PATCH 09/23] QDict: Rename 'err_value', Luiz Capitulino, 2010/07/01
- [Qemu-devel] [PATCH 08/23] QError: Enhance QERR_DEVICE_NOT_ACTIVE's user desc, Luiz Capitulino, 2010/07/01
- [Qemu-devel] [PATCH 11/23] QDict: Introduce functions to retrieve QDictEntry values, Luiz Capitulino, 2010/07/01
- [Qemu-devel] [PATCH 10/23] QDict: Small terminology change, Luiz Capitulino, 2010/07/01
- [Qemu-devel] [PATCH 13/23] check-qdict: Introduce test for the new iteration API, Luiz Capitulino, 2010/07/01
- [Qemu-devel] [PATCH 14/23] QDict: Introduce qdict_get_try_bool(), Luiz Capitulino, 2010/07/01
- [Qemu-devel] [PATCH 12/23] QDict: Introduce new iteration API, Luiz Capitulino, 2010/07/01
- [Qemu-devel] [PATCH 15/23] Monitor: handle optional '-' arg as a bool, Luiz Capitulino, 2010/07/01
- [Qemu-devel] [PATCH 16/23] QMP: New argument checker (first part), Luiz Capitulino, 2010/07/01