[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 06/23] net: delete QemuOpts when net_client_init() f

From: Luiz Capitulino
Subject: [Qemu-devel] [PATCH 06/23] net: delete QemuOpts when net_client_init() fails.
Date: Thu, 1 Jul 2010 16:21:34 -0300

From: Yoshiaki Tamura <address@hidden>

This fixes the following scenario using QMP.

First, put a bogus argument "foo" to "type", which results in an error.
{"execute": "netdev_add", "arguments": { "type": "foo", "id": "netdev1" } }
Then, call it again with correct argument "user".
{"execute": "netdev_add", "arguments": { "type": "user", "id": "netdev1" } }
This results in "DuplicatedId" error.

Because the first command was invalid, it should be able to reuse the
same "id", and the second command should work.

Reported-by: Luiz Capitulino <address@hidden>
Signed-off-by: Yoshiaki Tamura <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>
 net.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/net.c b/net.c
index 90bd5a9..8ddf872 100644
--- a/net.c
+++ b/net.c
@@ -1208,6 +1208,10 @@ int do_netdev_add(Monitor *mon, const QDict *qdict, 
QObject **ret_data)
     res = net_client_init(mon, opts, 1);
+    if (res < 0) {
+        qemu_opts_del(opts);
+    }
     return res;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]