[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 04/11] scsi: Reject unimplemented error actions
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] Re: [PATCH 04/11] scsi: Reject unimplemented error actions |
Date: |
Mon, 05 Jul 2010 18:26:53 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Kevin Wolf <address@hidden> writes:
> Am 30.06.2010 13:55, schrieb Markus Armbruster:
>> drive_init() doesn't permit rerror for if=scsi, but that's worthless:
>> we get it via if=none and -device.
>>
>> Moreover, scsi-generic doesn't support werror. Since drive_init()
>> doesn't catch that, option werror was silently ignored even with
>> if=scsi.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>
> It's still not entirely right, of course. You can explicitly request
> werror=enospc and the VM will start successfully, but silently ignore
> ENOSPC errors.
Yes, I took a shortcut here :)
Obvious fix is a separate default action. Drivers supporting werror
interpret it as "enospc". Drivers not supporting werror interpret it as
"do nothing", and reject any other option. Similar for rerror.
> Anyway, it's better than before.