[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 05/13] qdev: Don't hw_error() in qdev_init_nofail
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v2 05/13] qdev: Don't hw_error() in qdev_init_nofail() |
Date: |
Tue, 6 Jul 2010 14:08:48 +0200 |
Some of the failures are internal errors, and hw_error() is okay then.
But the common way to fail is bad user input, e.g. -global
isa-fdc.driveA=foo where drive foo has an unsupported rerror value.
exit(1) instead.
Signed-off-by: Markus Armbruster <address@hidden>
---
hw/qdev.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/qdev.c b/hw/qdev.c
index 61f999c..00ceada 100644
--- a/hw/qdev.c
+++ b/hw/qdev.c
@@ -326,8 +326,10 @@ void qdev_init_nofail(DeviceState *dev)
{
DeviceInfo *info = dev->info;
- if (qdev_init(dev) < 0)
- hw_error("Initialization of device %s failed\n", info->name);
+ if (qdev_init(dev) < 0) {
+ error_report("Initialization of device %s failed\n", info->name);
+ exit(1);
+ }
}
/* Unlink device from bus and free the structure. */
--
1.6.6.1
- [Qemu-devel] [PATCH v2 10/13] ide: Replace IDEState members is_cdrom, is_cf by drive_kind, (continued)
- [Qemu-devel] [PATCH v2 10/13] ide: Replace IDEState members is_cdrom, is_cf by drive_kind, Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH v2 11/13] ide: Make ide_init_drive() return success, Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH v2 07/13] error: New qemu_opts_loc_restore(), Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH v2 09/13] ide: Improve error messages, Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH v2 04/13] fdc: Reject unimplemented error actions, Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH v2 05/13] qdev: Don't hw_error() in qdev_init_nofail(),
Markus Armbruster <=
- [Qemu-devel] [PATCH v2 01/13] blockdev: Clean up how readonly persists across virtual media change, Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH v2 02/13] block migration: Fix test for read-only drive, Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH v2 03/13] raw-posix: Fix test for host CD-ROM, Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH v2 06/13] scsi: Reject unimplemented error actions, Markus Armbruster, 2010/07/06