[Qemu-devel] Re: [SeaBIOS] [PATCH 2/2] seabios: pciinit: use pci device initializer helper function.

[Kevin O'Connor]

On Mon, Jul 05, 2010 at 11:22:29AM +0900, Isaku Yamahata wrote:
> This patch makes use of pci device initialization helper function
> to convert if/switch clause to table driven.
> So this makes it easier to add q35 initialization code.

Looks okay to me.  A couple of minor comments..

>  SRC32FLAT=$(SRCBOTH) post.c shadow.c memmap.c coreboot.c boot.c \
>        acpi.c smm.c mptable.c smbios.c pciinit.c optionroms.c mtrr.c \
> -      lzmadecode.c bootsplash.c jpeg.c usb-hub.c paravirt.c
> +      lzmadecode.c bootsplash.c jpeg.c usb-hub.c paravirt.c i440fx.c

The "i440fx.c" is a bit cryptic for someone unfamiliar with the hardware.
Maybe "dev-i440fx.c" or something similar?

> +++ b/src/i440fx.h
> @@ -0,0 +1,17 @@
> +// initialization function which are specific to i440fx chipset
> +//
> +// Copyright (C) 2008  Kevin O'Connor <address@hidden>
> +// Copyright (C) 2006 Fabrice Bellard
> +//
> +// Copyright (C) 2010 Isaku Yamahata <yamahata at valinux co jp>
> +// Split out from pciinit.c
> +//
> +// This file may be distributed under the terms of the GNU LGPLv3 license.
> +#ifndef __I440FX_H
> +#define __I440FX_H
> +
> +void piix_isa_bridge_init(u16 bdf, void *arg);
> +void piix_ide_init(u16 bdf, void *arg);
> +void piix4_pm_init(u16 bdf, void *arg);
> +
> +#endif // __I440FX_H

I would prefer not to add long copyright statements on function
prototypes.  Lets copyright the code, not the headers.

-Kevin