[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [SeaBIOS] [PATCH 6/7] seabios: acpi: split out piix4 pm
From: |
Kevin O'Connor |
Subject: |
[Qemu-devel] Re: [SeaBIOS] [PATCH 6/7] seabios: acpi: split out piix4 pm logic. |
Date: |
Mon, 12 Jul 2010 21:02:39 -0400 |
User-agent: |
Mutt/1.5.20 (2009-12-10) |
On Mon, Jul 12, 2010 at 08:47:51PM +0900, Isaku Yamahata wrote:
> split out piix4 pm logic.
[...]
> @@ -202,11 +203,6 @@ static inline u16 cpu_to_le16(u16 x)
> return x;
> }
>
> -static inline u32 cpu_to_le32(u32 x)
> -{
> - return x;
> -}
This is a nitpick, but if cpu_to_le32() is moved to a header then
cpu_to_le16() needs to be moved to. It should also be moved to where
ntohl() is defined (util.h).
-Kevin
- [Qemu-devel] [PATCH 2/7] seabios: shadow: make device finding more generic., (continued)
- [Qemu-devel] [PATCH 3/7] seabios: smm: move out piix4 specific logic to dev-i440fx.c, Isaku Yamahata, 2010/07/12
- [Qemu-devel] [PATCH 5/7] seabios: acpi: move acpi definitions to acpi.h from acpi.c, Isaku Yamahata, 2010/07/12
- [Qemu-devel] [PATCH 1/7] seabios: pci: introduce helper function to find device from table and initialize it., Isaku Yamahata, 2010/07/12
- [Qemu-devel] [PATCH 7/7] seabios: acpi: clean up of finding pm device., Isaku Yamahata, 2010/07/12
- [Qemu-devel] [PATCH 4/7] seabios: smm_init: move out i440fx smram operation into dev-i440fx.c, Isaku Yamahata, 2010/07/12
- [Qemu-devel] [PATCH 6/7] seabios: acpi: split out piix4 pm logic., Isaku Yamahata, 2010/07/12
- [Qemu-devel] Re: [SeaBIOS] [PATCH 6/7] seabios: acpi: split out piix4 pm logic.,
Kevin O'Connor <=
- [Qemu-devel] Re: [SeaBIOS] [PATCH 0/7] abstract chipset(i440fx) specific register operation., Kevin O'Connor, 2010/07/12