[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 8/8] vlan cleanup: remove usage of VLANState
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH 8/8] vlan cleanup: remove usage of VLANState |
Date: |
Wed, 14 Jul 2010 09:18:44 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Markus Armbruster wrote:
> Miguel Di Ciurcio Filho <address@hidden> writes:
>> diff --git a/qemu-monitor.hx b/qemu-monitor.hx
>> index 275f3bc..e2c2a75 100644
>> --- a/qemu-monitor.hx
>> +++ b/qemu-monitor.hx
>> @@ -1224,8 +1224,8 @@ EQMP
>> #ifdef CONFIG_SLIRP
>> {
>> .name = "hostfwd_add",
>> - .args_type = "arg1:s,arg2:s?,arg3:s?",
>> - .params = "[vlan_id name]
>> [tcp|udp]:[hostaddr]:hostport-[guestaddr]:guestport",
>> + .args_type = "arg1:s,arg2:s?",
>> + .params = "[tcp|udp]:[hostaddr]:hostport-[guestaddr]:guestport",
>> .help = "redirect TCP or UDP connections from host to guest
>> (requires -net user)",
>> .mhandler.cmd = net_slirp_hostfwd_add,
>> },
>
> params is inconsistent with args_type and net_slirp_hostfwd_add().
Instead of the vlan ID, we need the netdev ID here - actually already
now because we can set up multiple slirp netdevs but cannot address them
via hostfwd_add/remove.
Jan
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 1/8] vlan cleanup: update documentation, (continued)
- [Qemu-devel] [PATCH 3/8] vlan cleanup: do not depend on socket and dump, Miguel Di Ciurcio Filho, 2010/07/12
- [Qemu-devel] [PATCH 2/8] vlan cleanup: update options, Miguel Di Ciurcio Filho, 2010/07/12
- [Qemu-devel] [PATCH 4/8] vlan cleanup: do not build socket and dump, Miguel Di Ciurcio Filho, 2010/07/12
- [Qemu-devel] [PATCH 5/8] vlan cleanup: remove socket.h and socket.c, Miguel Di Ciurcio Filho, 2010/07/12
- [Qemu-devel] [PATCH 6/8] vlan cleanup: remove dump.h and dump.c, Miguel Di Ciurcio Filho, 2010/07/12
- [Qemu-devel] [PATCH 7/8] vlan cleanup: remove legacy monitor commands, Miguel Di Ciurcio Filho, 2010/07/12
- [Qemu-devel] [PATCH 8/8] vlan cleanup: remove usage of VLANState, Miguel Di Ciurcio Filho, 2010/07/12
- [Qemu-devel] Re: [PATCH 0/8] vlan cleanup, Jan Kiszka, 2010/07/13
- [Qemu-devel] Re: [PATCH 0/8] vlan cleanup, Miguel Di Ciurcio Filho, 2010/07/13
- [Qemu-devel] Re: [PATCH 0/8] vlan cleanup, Jan Kiszka, 2010/07/13
- [Qemu-devel] Re: [PATCH 0/8] vlan cleanup, Anthony Liguori, 2010/07/13
- [Qemu-devel] Re: [PATCH 0/8] vlan cleanup, Jan Kiszka, 2010/07/13
- [Qemu-devel] Re: [PATCH 0/8] vlan cleanup, Anthony Liguori, 2010/07/13
- [Qemu-devel] Re: [PATCH 0/8] vlan cleanup, Jan Kiszka, 2010/07/13
- [Qemu-devel] Re: [PATCH 0/8] vlan cleanup, Markus Armbruster, 2010/07/14
- [Qemu-devel] Re: [PATCH 0/8] vlan cleanup, Jan Kiszka, 2010/07/14