[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 1/7] Generic IOMMU layer
From: |
Eduard - Gabriel Munteanu |
Subject: |
Re: [Qemu-devel] [RFC PATCH 1/7] Generic IOMMU layer |
Date: |
Thu, 15 Jul 2010 01:47:16 +0300 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Wed, Jul 14, 2010 at 10:07:20AM +0400, malc wrote:
> On Wed, 14 Jul 2010, Eduard - Gabriel Munteanu wrote:
>
> > This provides an API for abstracting IOMMU functions. Hardware emulation
> > code can use it to request address translation and access checking. In
> > the absence of an emulated IOMMU, no translation/checking happens and
> > I/O goes through as before.
> >
> > IOMMU emulation code must provide implementation-specific hooks for this
> > layer.
> >
>
> [..snip..]
>
> > +int __iommu_rw(struct iommu *iommu,
> > + DeviceState *dev,
> > + target_phys_addr_t addr,
> > + uint8_t *buf,
> > + int len,
> > + int is_write)
>
> Do not use leading double underscore.
>
> [..snip..]
>
> --
> mailto:address@hidden
Thanks, will fix it.
Eduard
[Qemu-devel] [RFC PATCH 7/7] ac97: IOMMU support, Eduard - Gabriel Munteanu, 2010/07/14
[Qemu-devel] [RFC PATCH 6/7] eepro100: IOMMU support, Eduard - Gabriel Munteanu, 2010/07/14
[Qemu-devel] [RFC PATCH 1/7] Generic IOMMU layer, Eduard - Gabriel Munteanu, 2010/07/14
[Qemu-devel] [RFC PATCH 5/7] rtl8139: IOMMU support, Eduard - Gabriel Munteanu, 2010/07/14
[Qemu-devel] [RFC PATCH 2/7] AMD IOMMU emulation, Eduard - Gabriel Munteanu, 2010/07/14