[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH 1/2] pci/bridge: allocate PCIBus dynamically
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] Re: [PATCH 1/2] pci/bridge: allocate PCIBus dynamically for PCIBridge. |
Date: |
Fri, 16 Jul 2010 10:35:53 +0300 |
User-agent: |
Mutt/1.5.20 (2009-12-10) |
On Fri, Jul 16, 2010 at 10:46:52AM +0900, Isaku Yamahata wrote:
> On Thu, Jul 08, 2010 at 07:49:35PM +0300, Michael S. Tsirkin wrote:
>
> > > For root bus:
> > > - pci_host_bus_new()/pci_host_bus_new_inplace()
> > > qbus style api. pci segment must be specified.
> > > New code should use this.
> >
> > I'd prefer a simple _init which works like _inplace.
> > Allocating memory is simple enough for users.
>
> How about the following patch?
> - replaced pci_bus_new(), pci_bus_new_inplace() with
> pci_host_bus_init()/pci_host_bus_cleanup()
> - eliminated memory allocation by embedding PCIBus into PCIHostState.
> I've tested it with only piix4 yet.
> If this direction is okay, I'll give it more tests and post it.
>
Looks good to me. What do others think? Let's also make
pci_host_bus_init_simple inline.
--
MST
- [Qemu-devel] [PATCH 1/2] pci/bridge: allocate PCIBus dynamically for PCIBridge., (continued)
- [Qemu-devel] [PATCH 1/2] pci/bridge: allocate PCIBus dynamically for PCIBridge., Isaku Yamahata, 2010/07/01
- [Qemu-devel] Re: [PATCH 1/2] pci/bridge: allocate PCIBus dynamically for PCIBridge., Michael S. Tsirkin, 2010/07/06
- [Qemu-devel] Re: [PATCH 1/2] pci/bridge: allocate PCIBus dynamically for PCIBridge., Michael S. Tsirkin, 2010/07/08
- Re: [Qemu-devel] Re: [PATCH 1/2] pci/bridge: allocate PCIBus dynamically for PCIBridge., Isaku Yamahata, 2010/07/08
- Re: [Qemu-devel] Re: [PATCH 1/2] pci/bridge: allocate PCIBus dynamically for PCIBridge., Michael S. Tsirkin, 2010/07/08
- Re: [Qemu-devel] Re: [PATCH 1/2] pci/bridge: allocate PCIBus dynamically for PCIBridge., Isaku Yamahata, 2010/07/08
- Re: [Qemu-devel] Re: [PATCH 1/2] pci/bridge: allocate PCIBus dynamically for PCIBridge., Isaku Yamahata, 2010/07/15
- Re: [Qemu-devel] Re: [PATCH 1/2] pci/bridge: allocate PCIBus dynamically for PCIBridge.,
Michael S. Tsirkin <=
[Qemu-devel] [PATCH 2/2] pci/bridge: split out pci bridge code into pci_bridge.c from pci.c, Isaku Yamahata, 2010/07/01