[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block migraton: check sectors before shift ope
From: |
Yoshiaki Tamura |
Subject: |
Re: [Qemu-devel] [PATCH] block migraton: check sectors before shift operation. |
Date: |
Mon, 19 Jul 2010 20:22:33 +0900 |
2010/7/19 Kevin Wolf <address@hidden>:
> Am 19.07.2010 06:45, schrieb Yoshiaki Tamura:
>> Commit d246673dcb9911218ff555bcdf28b250e38fa46c has expanded the types
>> of block drive that can be initialized for block migration. Although
>> bdrv_getlength() may return < 0, current code shifts it without
>> checking. This makes block migration initialization invalid and
>> results in abort() due to calling qemu_malloc() with 0 size at
>> bdrv_set_dirty_tracking(). This patch checks the return value of
>> bdrv_getlength() by masking with BDRV_SECTOR_MASK.
>>
>> Signed-off-by: Yoshiaki Tamura <address@hidden>
>
> I applied a similar patch by Shahar Havivi to the block branch a few
> days ago.
Oops. Missed that discussion.
Yoshi
>
> Kevin
>
>