qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] rtc: Remove TARGET_I386 from qemu-config.c,


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH v2] rtc: Remove TARGET_I386 from qemu-config.c, enables driftfix
Date: Mon, 09 Aug 2010 08:29:47 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.11) Gecko/20100713 Lightning/1.0b1 Thunderbird/3.0.6

On 08/06/2010 03:40 PM, Amit Shah wrote:
On (Fri) Aug 06 2010 [12:12:45], Daniel P. Berrange wrote:
On Wed, Jun 23, 2010 at 08:14:04PM +0530, Amit Shah wrote:
qemu-config.c doesn't contain any target-specific code, and the
TARGET_I386 conditional code didn't get compiled as a result. Removing
this enables the driftfix parameter for rtc.

Signed-off-by: Amit Shah<address@hidden>
---
  qemu-config.c |    2 --
  1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/qemu-config.c b/qemu-config.c
index 95abe61..730ffd9 100644
--- a/qemu-config.c
+++ b/qemu-config.c
@@ -247,11 +247,9 @@ QemuOptsList qemu_rtc_opts = {
          },{
              .name = "clock",
              .type = QEMU_OPT_STRING,
-#ifdef TARGET_I386
          },{
              .name = "driftfix",
              .type = QEMU_OPT_STRING,
-#endif
          },
          { /* end if list */ }
      },

Is there any reason this patch hasn't been applied to GIT yet ? I'm told
that using this option is critical to making certain guests work reliably
so we want to use it from libvirt/virt-manager for the OS in question.
Multiple pings have gone out already; I hope it's in someone's queue to
be applied

Sorry, I've got it now. In the future, please resend patches with [RESEND] as opposed to just bumping it.

Regards,

Anthony Liguori

                Amit




reply via email to

[Prev in Thread] Current Thread [Next in Thread]