[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH 3/5] CODING_STYLE: add memory management rul

From: Avi Kivity
Subject: Re: [Qemu-devel] Re: [PATCH 3/5] CODING_STYLE: add memory management rules
Date: Sun, 15 Aug 2010 19:06:42 +0300
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100720 Fedora/3.1.1-1.fc13 Lightning/1.0b2pre Thunderbird/3.1.1

 On 08/14/2010 12:01 AM, malc wrote:

This is all perfectly reasonable, but begs one question, where do we stop
codifying self-evident truths (or who is the ultimiate judge of what is
self-evident and what isn't), since taking the above to extreme we will
end up adding stuff like: you must use close to dispose of open-ed
descriptors and such like.

It's a matter of pragmatism, if a lot of patches are routinely rejected due to some error then it makes sense to add it to CODING_STYLE, even if they are not exactly style decisions. If not then they just dilute that document.

error compiling committee.c: too many arguments to function

reply via email to

[Prev in Thread] Current Thread [Next in Thread]