[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments

From: Blue Swirl
Subject: Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments
Date: Tue, 17 Aug 2010 18:56:43 +0000

On Tue, Aug 17, 2010 at 1:55 PM, Jes Sorensen <address@hidden> wrote:
> On 08/17/10 15:21, Anthony Liguori wrote:
>> On 08/17/2010 03:04 AM, Jes Sorensen wrote:
>>> On 08/13/10 20:02, Blue Swirl wrote:
>>>> I fully agree on the need of change and support your excellent idea.
>>>> There are other ways to solve the problem, but I believe we need more
>>>> order than more chaos. Perhaps we the QEMU developers should appoint
>>>> you the Guardian of the CODING_STYLE, and add a rule that no patch
>>>> shall be committed without your CS-Acked-by line?
>>> I don't think this would ever work, it is begging for trouble relying on
>>> one person to review all patches for this.
>>> While I agree coding style is good since it enforces consistency, there
>>> are plenty problems with the old rules
>> To be perfectly honest, we have enough hard problems to solve in QEMU.
>> We're spending a lot more time on coding style than we probably need to :-)
> I think we are in full agreement here, I am really just worried that we
> add additional procedures here that will slow down the real development.

Either the braces rule in CODING_STYLE is downgraded to
recommendation, or some kind of new order is introduced. Current
situation is unfair.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]