[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 7/9] spice: add mouse

From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 7/9] spice: add mouse
Date: Fri, 20 Aug 2010 14:42:49 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100720 Red Hat/3.1.1-1.el6 Thunderbird/3.1.1


+static void mouse_motion(SpiceMouseInstance *sin, int dx, int dy, int
+ uint32_t buttons_state)
+ kbd_mouse_event(dx, dy, dz, buttons_state);

dz is an odd interface. We use it to represent additional buttons which
really makes no sense. If you still can, I'd suggest moving dz into

Again this is libspice interface (and I think also wire protocol), so I can't change it. I can convert dz into some button_mask bits before calling kbd_mouse_event, but looking at the vnc code it seems qemu expects the mouse wheel events being passed via dz not button_state.

Previous comment still applies though, you should explicitly convert the
button_states from QEMU format to Spice format to future proof.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]