[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments

From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments
Date: Sun, 22 Aug 2010 23:41:47 +0300
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100806 Fedora/3.1.2-1.fc13 Thunderbird/3.1.2

 On 08/22/2010 11:17 PM, Anthony Liguori wrote:
On 08/22/2010 03:09 PM, Avi Kivity wrote:
 On 08/22/2010 09:56 PM, Blue Swirl wrote:

Can someone point to a bug in QEMU that's been caused because of
CODING_STYLE or the fact that some patches don't adhere to it?

How was this bug caused by CODING_STYLE? In fact, if CODING_STYLE was applied correctly then this bug would stand out much more:

    if (...) {
        /* .... */;

"or the fact that some patches don't adhere to it". If CODING_STYLE was enforced at commit time, this bug would not have happened most likely.

Ah, yes.

But it's such an odd case that I'd say it's just the exception that proves the rule that a loose CODING_STYLE isn't significantly impacting overall quality.

I agree. IMO a consistent coding style is mainly an aid to the reader, the brain has one less thing to disentangle.

I also don't believe that it's creating distress in contributors. I believe timely patch review/commit is probably a more important issue for contributors than whether some people get by without CODING_STYLE being strictly enforced.

Definitely.  Especially as people can adjust to CODING_STYLE.

I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]