|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [PATCH 1/3] Add TPM 1.2 host device passthrough interface |
Date: | Thu, 26 Aug 2010 16:57:59 -0500 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.11) Gecko/20100713 Lightning/1.0b1 Thunderbird/3.0.6 |
On 08/26/2010 04:44 PM, malc wrote:
and lastly there is no errx[1] [..snip..] [1] err(3): CONFORMING TO These functions are non-standard BSD extensions.err() and errx() are already used somewhere. But these should be converted to error_report etc., like other printf based local functions.Only in Linux specific nbd code.
And the nbd stuff is derived from non-QEMU code that was brought into the tree. It's generally a bad example of QEMU coding style.
Regards, Anthony Liguori
[Prev in Thread] | Current Thread | [Next in Thread] |