[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH v3 2/3] qerror: Add a new MACHINE_STOPPED error

From: Anthony Liguori
Subject: [Qemu-devel] Re: [PATCH v3 2/3] qerror: Add a new MACHINE_STOPPED error message
Date: Fri, 27 Aug 2010 07:39:37 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100713 Lightning/1.0b1 Thunderbird/3.0.6

On 08/27/2010 04:29 AM, Daniel P. Berrange wrote:
On Fri, Aug 27, 2010 at 10:57:10AM +0530, Amit Shah wrote:
This error message denotes some command was not successful in completing
as the guest was unresponsive.

Use it in the virtio-balloon code when showing older, cached data.

Signed-off-by: Amit Shah<address@hidden>
  hw/virtio-balloon.c |    1 +
  qerror.c            |    4 ++++
  qerror.h            |    3 +++
  3 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c
index d6c66cf..309c343 100644
--- a/hw/virtio-balloon.c
+++ b/hw/virtio-balloon.c
@@ -140,6 +140,7 @@ static void complete_stats_request(VirtIOBalloon *vb)

  static void show_old_stats(void *opaque)
+    qerror_report(QERR_MACHINE_STOPPED);

NACK. It has always been allowed&  valid to call query-balloon
to get the current balloon level. We must not throw an error
just because the recently added mem stats can't be refreshed.

I think that's a fair comment but why even bother fixing the command. Let's introduce a new command that just gets a single piece of information instead of having a command return lots of information.


Anthony Liguori


reply via email to

[Prev in Thread] Current Thread [Next in Thread]