|
From: | Bernhard Kohl |
Subject: | Re: [Qemu-devel] [PATCH 2/4] scsi-disk: fix the mode data header returned by the MODE SENSE(10) command |
Date: | Fri, 27 Aug 2010 17:24:40 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.11) Gecko/20100720 Fedora/3.0.6-1.fc12 Thunderbird/3.0.6 |
Am 16.08.2010 19:02, schrieb ext Kevin Wolf:
> + if (bdrv_get_type_hint(s->bs) == BDRV_TYPE_CDROM || > + bdrv_is_read_only(s->bs)) { This looks like a mismerge. The check for CDROMs was removed when they became read-only by definition. Please don't reintroduce it.
OK, I will remove that check in v2.
> + if (req->cmd.buf[0] == MODE_SENSE) > + outbuf[3] = 8; /* Block descriptor length */ > + else /* MODE_SENSE_10 */ > + outbuf[7] = 8; /* Block descriptor length */ Please add curly braces here (see CODING_STYLE).
OK, I will add curly braces in v2. Bernhard
[Prev in Thread] | Current Thread | [Next in Thread] |