[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] QEMUFileBuffered: indicate that we're ready whe

From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH] QEMUFileBuffered: indicate that we're ready when the underlying file is ready
Date: Sun, 29 Aug 2010 12:00:28 +0300
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100806 Fedora/3.1.2-1.fc13 Lightning/1.0b2pre Thunderbird/3.1.2

 On 08/19/2010 06:19 PM, Anthony Liguori wrote:
On 07/07/2010 11:44 AM, Avi Kivity wrote:
QEMUFileBuffered stops writing when the underlying QEMUFile is not ready, and tells its producer so. However, when the underlying QEMUFile becomes
ready, it neglects to pass that information along, resulting in stoppage
of all data until the next tick (a tenths of a second).

Usually this doesn't matter, because most QEMUFiles used with QEMUFileBuffered are almost always ready, but in the case of exec: migration this is not true, due to the small pipe buffers used to connect to the target process. The
result is very slow migration.

Fix by detecting the readiness notification and propagating it. The detection is a little ugly since QEMUFile overloads put_buffer() to send it, but that's
the suject for a different patch.

Signed-off-by: Avi Kivity<address@hidden>\

Applied.  Thanks.

Should be applied to stable-0.13 as well.

error compiling committee.c: too many arguments to function

reply via email to

[Prev in Thread] Current Thread [Next in Thread]