[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH 10/14] Zero json struct with memset() instea

From: Paolo Bonzini
Subject: Re: [Qemu-devel] Re: [PATCH 10/14] Zero json struct with memset() instea of = {} to keep compiler happy.
Date: Mon, 30 Aug 2010 18:18:38 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Mnenhy/0.8.3 Thunderbird/3.0.5

On 08/30/2010 06:15 PM, Anthony Liguori wrote:
On 08/30/2010 10:42 AM, Paolo Bonzini wrote:
On 08/30/2010 05:35 PM, address@hidden wrote:
- JSONParsingState state = {};
+ JSONParsingState state;

+ memset(&state, 0, sizeof(state));
state.ap = ap;

JSONParsingState state = { .ap = ap };

achieves the same.

But the fundamental is, what problem does GCC have with the original? If
there isn't a reasonable answer, then I'm inclined to think this warning
mode is a waste of time.

It falls under the "missing fields in initializer" warning. Arguably, an empty initializer should be special cased, but it isn't.

I agree that Jes's original patch is ugly, but the C99 initializer is an improvement.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]