[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 14/25] scsi-disk: fix the block descriptor returned
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH 14/25] scsi-disk: fix the block descriptor returned by the MODE SENSE command |
Date: |
Wed, 8 Sep 2010 15:29:31 +0200 |
From: Bernhard Kohl <address@hidden>
The block descriptor contains the number of blocks, not the highest LBA.
Real hard disks return 0 if the number of blocks exceed the maximum 0xFFFFFF.
SCSI-Spec:
http://ldkelley.com/SCSI2/SCSI2/SCSI2-08.html#8.3.3
"The number of blocks field specifies the number of logical blocks on the
medium to which the density code and block length fields apply. A value
of zero indicates that all of the remaining logical blocks of the logical
unit shall have the medium characteristics specified."
Signed-off-by: Bernhard Kohl <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
hw/scsi-disk.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 1287cab..e085d5b 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -662,9 +662,8 @@ static int scsi_disk_emulate_mode_sense(SCSIRequest *req,
uint8_t *outbuf)
outbuf[7] = 8; /* Block descriptor length */
}
nb_sectors /= s->cluster_size;
- nb_sectors--;
if (nb_sectors > 0xffffff)
- nb_sectors = 0xffffff;
+ nb_sectors = 0;
p[0] = 0; /* media density code */
p[1] = (nb_sectors >> 16) & 0xff;
p[2] = (nb_sectors >> 8) & 0xff;
--
1.7.2.2
- [Qemu-devel] [PULL v2 00/25] Block patches, Kevin Wolf, 2010/09/08
- [Qemu-devel] [PATCH 06/25] vvfat: fat_chksum(): fix access above array bounds, Kevin Wolf, 2010/09/08
- [Qemu-devel] [PATCH 17/25] scsi: fix and improve debug prints, Kevin Wolf, 2010/09/08
- [Qemu-devel] [PATCH 15/25] scsi-disk: return CHECK CONDITION for unknown page codes in the MODE SENSE command, Kevin Wolf, 2010/09/08
- [Qemu-devel] [PATCH 22/25] raw-posix: improve detection of scsi-generic devices, Kevin Wolf, 2010/09/08
- [Qemu-devel] [PATCH 25/25] qcow2: Remove unnecessary flush after L2 write, Kevin Wolf, 2010/09/08
- [Qemu-devel] [PATCH 14/25] scsi-disk: fix the block descriptor returned by the MODE SENSE command,
Kevin Wolf <=
- [Qemu-devel] [PATCH 18/25] qemu-io: Make alloc output useful when nb_sectors=1, Kevin Wolf, 2010/09/08
- [Qemu-devel] [PATCH 02/25] virtio-blk: Fix migration of queued requests, Kevin Wolf, 2010/09/08
- [Qemu-devel] [PATCH 05/25] qemu-img rebase: Open new backing file read-only, Kevin Wolf, 2010/09/08
- [Qemu-devel] [PATCH 24/25] block: Fix BDRV_O_CACHE_MASK, Kevin Wolf, 2010/09/08
- [Qemu-devel] [PATCH 20/25] Improve ATA IDENTIFY word 64 contents., Kevin Wolf, 2010/09/08
- [Qemu-devel] [PATCH 23/25] qemu-img convert: Use cache=unsafe for output image, Kevin Wolf, 2010/09/08
- [Qemu-devel] [PATCH 21/25] scsi-disk: add some optional scsi commands, Kevin Wolf, 2010/09/08
- [Qemu-devel] [PATCH 07/25] nbd: Introduce NBD named exports., Kevin Wolf, 2010/09/08
- [Qemu-devel] [PATCH 19/25] raw-posix: Don't use file name for host_cdrom detection on Linux, Kevin Wolf, 2010/09/08
- [Qemu-devel] [PATCH 03/25] block: Fix image re-open in bdrv_commit, Kevin Wolf, 2010/09/08