|
From: | Jes Sorensen |
Subject: | [Qemu-devel] Re: [PATCH 2/5] Support human unit formats in strtobytes, eg. 1.0G |
Date: | Wed, 15 Sep 2010 21:29:30 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100907 Fedora/3.1.3-1.fc13 Lightning/1.0b3pre Thunderbird/3.1.3 |
On 09/15/10 16:50, Juan Quintela wrote: > address@hidden wrote: >> From: Jes Sorensen <address@hidden> >> value <<= 10; >> break; >> case 0: >> + if (divider) { >> + value = 0; >> + break; > > changing break by goto fail here? > 1.5G and 1.0G is ok, but using 1024.00 or similar should be one error, > no? > > nice cleanup for the rest of the patch series. In my testing, 1234.5 fails as expected, so I expect 1024.00 to fail as well. Cheers, Jes
[Prev in Thread] | Current Thread | [Next in Thread] |