[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 1/3] block: allow migration to work with image f
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] Re: [PATCH 1/3] block: allow migration to work with image files |
Date: |
Thu, 16 Sep 2010 09:54:42 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.12) Gecko/20100907 Fedora/3.0.7-1.fc12 Thunderbird/3.0.7 |
Am 15.09.2010 18:03, schrieb Juan Quintela:
> Kevin Wolf <address@hidden> wrote:
>> Am 11.09.2010 16:04, schrieb Anthony Liguori:
>
>> There is a simple generic implementation:
>>
>> drv = bs->drv;
>> drv->close(bs);
>> drv->open(bs, bs->open_flags);
>>
>> Note that this only reopens e.g. the qcow2 layer, but not the image
>> file, which is bs->file.
>>
>> This works for all simple case, that is, one format on top of one or
>> more protocols, where the protocols don't need invalidation. I think
>> this includes everything that is possible today. With -blockdev we might
>> need to revise this to include the lower layers, too. (But only
>> sometimes, because we don't want to reopen the file)
>
> we require it for nfs consistency. We need to:
>
> source: fsync()
> target: open() (after the fsync).
>
> About your 1st comment, I am doing:
>
> bdrv_close(bdrv);
> bdrv_open(bdrv);
>
> Do you mean that this don't close and open again the file with qcow2?
It does. bdrv_open/close take care of the whole stack.
Kevin
- Re: [Qemu-devel] [PATCH 1/3] block: allow migration to work with image files, (continued)
- Re: [Qemu-devel] [PATCH 1/3] block: allow migration to work with image files, Avi Kivity, 2010/09/12
- Re: [Qemu-devel] [PATCH 1/3] block: allow migration to work with image files, Anthony Liguori, 2010/09/12
- Re: [Qemu-devel] [PATCH 1/3] block: allow migration to work with image files, Avi Kivity, 2010/09/12
- Re: [Qemu-devel] [PATCH 1/3] block: allow migration to work with image files, Anthony Liguori, 2010/09/12
- Re: [Qemu-devel] [PATCH 1/3] block: allow migration to work with image files, Avi Kivity, 2010/09/12
- [Qemu-devel] Re: [PATCH 1/3] block: allow migration to work with image files, Juan Quintela, 2010/09/15
- [Qemu-devel] Re: [PATCH 1/3] block: allow migration to work with image files, Juan Quintela, 2010/09/15
[Qemu-devel] Re: [PATCH 1/3] block: allow migration to work with image files, Kevin Wolf, 2010/09/13
[Qemu-devel] Re: [PATCH 1/3] block: allow migration to work with image files, Juan Quintela, 2010/09/15
Re: [Qemu-devel] [RFC][PATCH 0/3] Fix caching issues with live migration, Avi Kivity, 2010/09/12