Re: [Qemu-devel] [PATCH] mingw: add version information to the executables

[Stefan Weil]

Could it be that the patch lines were wrapped by your mailer?
I cannot apply it here.

Regards, Stefan

Am 19.09.2010 10:42, schrieb Blue Swirl:
> Add QEMU version information to the executables, based on earlier
> work by C. W. Betts and Robert Riebisch.
>
> Signed-off-by: Blue Swirl<address@hidden>
> ---
>   Makefile      |   10 +++++++---
>   Makefile.objs |    1 +
>   configure     |   12 ++++++++++++
>   version.rc    |   28 ++++++++++++++++++++++++++++
>   4 files changed, 48 insertions(+), 3 deletions(-)
>   create mode 100644 version.rc
>
> diff --git a/Makefile b/Makefile
> index ab91d42..732858b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -114,16 +114,20 @@ trace.o: trace.c $(GENERATED_HEADERS)
>
>   simpletrace.o: simpletrace.c $(GENERATED_HEADERS)
>
> +version.o: $(SRC_PATH)/version.rc config-host.mak
> +       $(call quiet-command,$(WINDRES) -I. -o $@ $<,"  RC    $(TARGET_DIR)$@")
> +
> +version-obj-$(CONFIG_WIN32) += version.o
>   ######################################################################
>
>   qemu-img.o: qemu-img-cmds.h
>   qemu-img.o qemu-tool.o qemu-nbd.o qemu-io.o: $(GENERATED_HEADERS)
>
> -qemu-img$(EXESUF): qemu-img.o qemu-tool.o qemu-error.o $(trace-obj-y)
> $(block-obj-y) $(qobject-obj-y)
>    

Line wrapped? git complains. More lines like this follow.

> +qemu-img$(EXESUF): qemu-img.o qemu-tool.o qemu-error.o $(trace-obj-y)
> $(block-obj-y) $(qobject-obj-y) $(version-obj-y)
>
> -qemu-nbd$(EXESUF): qemu-nbd.o qemu-tool.o qemu-error.o $(trace-obj-y)
> $(block-obj-y) $(qobject-obj-y)
> +qemu-nbd$(EXESUF): qemu-nbd.o qemu-tool.o qemu-error.o $(trace-obj-y)
> $(block-obj-y) $(qobject-obj-y) $(version-obj-y)
>
> -qemu-io$(EXESUF): qemu-io.o cmd.o qemu-tool.o qemu-error.o
> $(trace-obj-y) $(block-obj-y) $(qobject-obj-y)
> +qemu-io$(EXESUF): qemu-io.o cmd.o qemu-tool.o qemu-error.o
> $(trace-obj-y) $(block-obj-y) $(qobject-obj-y) $(version-obj-y)
>    
[snip]