Re: [Qemu-devel] [PATCH v3 00/15] GCC warning flags

[Blue Swirl]

On Mon, Sep 20, 2010 at 11:28 AM, Stefan Weil <address@hidden> wrote:
> Am 10.09.2010 22:58, schrieb Blue Swirl:
>>
>> I updated the descriptions and cleaned up 6/16.
>>
>> Blue Swirl (15):
>> Check for errors during BIOS or kernel load
>> linux-user: fix socklen_t comparisons
>> linux-user: fix types in a comparison
>> linux-user: improve flatload error checking
>> Introduce range.h
>> Use range_covers_byte
>> pxa2xx: remove useless checks
>> blkdebug: fix enum comparison
>> PPC: Suppress gcc warnings with -Wtype-limits
>> MIPS: fix yield handling
>> pxa2xx: fix SSSR TFN logic
>> Use gcc warning flag -Wtype-limits
>> Use a few more gcc warning flags
>> Use gcc warning flag -Wempty-body
>> Use gcc warning flag -Wnested-externs
>
> [snip]
>
> -Wmissing-format-attribute is also a very useful warning flag.
> I have patches which add the missing format attributes, so
> this flag could be applied.
>
> Some of these patches were already send to qemu-devel:
> http://patchwork.ozlabs.org/patch/64643/
> http://patchwork.ozlabs.org/patch/64644/
> http://patchwork.ozlabs.org/patch/64487/
> http://patchwork.ozlabs.org/patch/64488/
>
> Although HACKING says that "patches to add the attribute would
> be very much appreciated", these patches were still not applied
> to QEMU master (not even reviewed).
>
> Sending a complete set patch of patches is some work for me
> (not because it is difficult, but because a lot of files
> are concerned). Is there a maintainer willing to support
> integration of my patches so that it does not take months
> for review and commit?

I'll review the patches and commit if there are no objections.