[Qemu-devel] Re: [PATCH 2/3] Replace remaining gcc format attribute by macro GCC_FMT_ATTR (format checking)

[Blue Swirl]

On Thu, Sep 23, 2010 at 7:28 PM, Stefan Weil <address@hidden> wrote:
> Replace the remaining format attribute printf by macro
> GCC_FMT_ATTR which uses gnu_printf (if supported).
>
> This needs additional code changes:
>
> * Add qemu-common.h (which defined GCC_FMT_ATTR) were needed.
>
> * Remove standard includes when qemu-common.h was added.
>  qemu-common.h already provides these includes.
>
> * Remove local definitions which now come from stdio.h.
>  These definitions were needed before tcg was introduced.
>  They raise conflicts when qemu-common.h is included.

IIRC the problem was that some system headers were incompatible with
global asm variables. There is still one, AREG0.

But I'd rather not keep the hideous local definitions forever. Maybe
those systems which are broken by the patch are not interesting
anymore?