[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 05/18] Monitor: Drop is_async_return()

From: Luiz Capitulino
Subject: Re: [Qemu-devel] [PATCH 05/18] Monitor: Drop is_async_return()
Date: Wed, 29 Sep 2010 10:28:21 -0300

On Wed, 29 Sep 2010 13:21:08 +0200
Markus Armbruster <address@hidden> wrote:

> Luiz Capitulino <address@hidden> writes:
> > If I understood it correcty, the is_async_return() logic was only
> > used to prevent QMP from issuing duplicated success responses
> > for asynchronous handlers.
> >
> > However, QMP doesn't use do_info() anymore so this is dead logic
> > and (hopefully) can be safely dropped.
> Looks like it.
> Does anybody understand this async monitor stuff?  

I guess I do, but every now and then it surprises me someway.

> It's used only for
> "info balloon" and "balloon".  It keeps getting in the way.  I'm sorely
> tempted to rip it out and reimplement it after we're done refactoring
> the monitor.

I've considered doing that, but then I realized that it's actually a good
interface with two serious problems:

  1. It's half done. A true async interface would provide a way to list and
     cancel requests (at the API level and in QMP/HMP)

  2. It got too complex, and that's so because of the current state of the
     Monitor code

My optimistic side is telling me that both problems can be solved during
the refactoring process: Monitor code will be simplified and the current
async interface could be used as the basis for the internal QMP API (which
should be async-only, but that's another discussion).

reply via email to

[Prev in Thread] Current Thread [Next in Thread]