[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 10/19] QMP: Introduce query commands dispatch ta
[Qemu-devel] Re: [PATCH 10/19] QMP: Introduce query commands dispatch table
Fri, 1 Oct 2010 10:49:06 -0300
On Fri, 01 Oct 2010 08:31:11 -0500
Anthony Liguori <address@hidden> wrote:
> On 09/30/2010 03:56 PM, Luiz Capitulino wrote:
> > The new table is a copy of HMP's table, containing only QObject
> > handlers.
> > In the near future HMP will be making QMP calls and then we will
> > be able to drop QObject handlers from HMP's table.
> > > From now on, QMP and HMP have different query command dispatch
> > tables.
> I like this series a lot and I think it's ready to merge.
> But I wonder, why have a separate qmp_query_cmds table? Why not just
> fold the query commands into qmp_cmds?
Yes, that will be done shortly, but in a different series.
I'm not doing it in this series because it's necessary to change the
signature of all those functions which would make this series too large and
harder to review.
On a related note: I have more monitor patches in my queue. I'm building
and testing them right now. I'm planning to send a pull request of all
pending monitor patches later today. So, if you prefer, you can wait for
that pull request instead of merging this series alone.
It will generate some noise on the list though, as I think it's good practice
to resend patches in a pull request to the list.