[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 05/11] Delete write only variables
From: |
Blue Swirl |
Subject: |
[Qemu-devel] Re: [PATCH 05/11] Delete write only variables |
Date: |
Thu, 7 Oct 2010 17:24:55 +0000 |
On Thu, Oct 7, 2010 at 7:27 AM, Paolo Bonzini <address@hidden> wrote:
> On 10/06/2010 11:32 PM, Blue Swirl wrote:
>>
>> @@ -91,8 +90,6 @@ static int vga_osi_call (CPUState *env)
>> env->gpr[3] = 0;
>> break;
>> case 39: /* video_ctrl */
>> - if (env->gpr[6] == 0 || env->gpr[6] == 1)
>> - vga_vbl_enabled = env->gpr[6];
>> env->gpr[3] = 0;
>> break;
>> case 47:
>
> NACK, this smells like an incomplete emulation.
Why would we care about unfinished temporary Mac-on-Linux hack for
video.x? Perhaps the correct fix is to remove vga_osi_call function
and env->osi_call field entirely.
- [Qemu-devel] [PATCH 05/11] Delete write only variables, Blue Swirl, 2010/10/06
- [Qemu-devel] Re: [PATCH 05/11] Delete write only variables, Paolo Bonzini, 2010/10/07
- [Qemu-devel] Re: [PATCH 05/11] Delete write only variables,
Blue Swirl <=
- [Qemu-devel] Re: [PATCH 05/11] Delete write only variables, Paolo Bonzini, 2010/10/08
- [Qemu-devel] Re: [PATCH 05/11] Delete write only variables, Alexander Graf, 2010/10/08
- [Qemu-devel] Re: [PATCH 05/11] Delete write only variables, Blue Swirl, 2010/10/08
- [Qemu-devel] Re: [PATCH 05/11] Delete write only variables, Alexander Graf, 2010/10/08
- Re: [Qemu-devel] Re: [PATCH 05/11] Delete write only variables, Andreas Färber, 2010/10/09
- Re: [Qemu-devel] Re: [PATCH 05/11] Delete write only variables, Alexander Graf, 2010/10/09