|
From: | Markus Armbruster |
Subject: | [Qemu-devel] virtio_cleanup() missing in virtio-{blk, balloon, 9p}-pci |
Date: | Mon, 11 Oct 2010 12:00:35 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Pattern: FOO's PCIDeviceInfo method exit is virtio_FOO_exit_pci(), which calls virtio_FOO_exit() and virtio_exit_pci(). virtio_{net,serial}_exit() call virtio_cleanup(). virtio_blk_exit() doesn't. Why? virtio-balloon-pci uses virtio_exit_pci() as exit method. No virtio_cleanup()? virtio-9p-pci doesn't have an exit method. Doesn't feel right. I suspect these three leak memory or worse on hot unplug.
[Prev in Thread] | Current Thread | [Next in Thread] |