[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specifica

From: Anthony Liguori
Subject: Re: [Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification
Date: Mon, 11 Oct 2010 12:14:45 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100915 Lightning/1.0b1 Thunderbird/3.0.8

On 10/11/2010 11:18 AM, Anthony Liguori wrote:
On 10/11/2010 10:46 AM, Stefan Hajnoczi wrote:
On Mon, Oct 11, 2010 at 05:39:01PM +0200, Avi Kivity wrote:
  On 10/11/2010 05:30 PM, Stefan Hajnoczi wrote:
It was discussed before, but I don't think we came to a conclusion. Are
  there any circumstances under which you don't want to set the
I suggest the following:


When set, the backing file is a raw image and should not be probed for
its file format. The default (unset) means that the backing image file
format may be probed.

Now the backing_fmt_{offset,size} are no longer necessary.
Should it not be an incompatible option?  If the backing disk starts
with a format magic, it will be probed by an older qemu,
Agreed, it should be a non-compat feature bit.

If it's just raw or not raw, then I agree it should be non-compat.

I think we just need a feature bit then that indicates that the backing file is non-probeable which certainly simplifies the implementation.


Er, thinking more, this is still a good idea but we still need QED_CF_BACKING_FORMAT because we specifically need to know when a protocol is specified. Otherwise, we have no way of doing nbd as a backing file.


Anthony Liguori


Anthony Liguori


reply via email to

[Prev in Thread] Current Thread [Next in Thread]