|
| From: | Paolo Bonzini |
| Subject: | Re: [Qemu-devel] [PATCH 08/39] provide portable sizeof(long) test |
| Date: | Tue, 12 Oct 2010 17:32:08 +0200 |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100907 Fedora/3.1.3-1.fc13 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.3 |
On 10/12/2010 05:12 PM, malc wrote:
Bottom line: QEMU assumes that long is large enough to hold a pointer, this assumption is wrong, and your patch is wrong (not because it miscalculates size of ABI long) but because of the assumptions current code has. Whether two wrongs makes right is an open question, currently Win64 isnot supported in any shape or form, even though Filip Navarra once did a port[1] which never went into mainline. [1] http://marc.info/?l=qemu-devel&m=124912692531724&w=2
His port apparently is fine with HOST_LONG_BITS == sizeof(void *), I'll adjust for v2.
Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |