[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 07/11] kvm, x86: unify sigbus handling, prep

From: Marcelo Tosatti
Subject: [Qemu-devel] Re: [PATCH 07/11] kvm, x86: unify sigbus handling, prep
Date: Thu, 14 Oct 2010 21:36:56 -0300
User-agent: Mutt/1.5.20 (2009-08-17)

On Thu, Oct 14, 2010 at 05:49:43PM +0900, Jin Dongming wrote:
> There are 2 similar functions to handle SIGBUS:
>   sigbus_handler(int n, struct qemu_signalfd_siginfo *siginfo,
>                  void *ctx)
>   kvm_on_sigbus(CPUState *env, siginfo_t *siginfo)
> The former is used when main thread receives SIGBUS via signalfd,
> while latter is used when vcpu thread receives SIGBUS.
> These 2 take different siginfo, but in both case required parameters
> are common, the code and the addr in the info.
> Restruct functions to take the code and the addr explicitly.
> Signed-off-by: Hidetoshi Seto <address@hidden>
> Tested-by: Jin Dongming <address@hidden>
> ---
>  qemu-kvm.c |   41 ++++++++++++++++++++---------------------
>  1 files changed, 20 insertions(+), 21 deletions(-)

Don't see the benefit, separate functions are cleaner.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]