[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 5/9] Move qemu_gettimeofday() to OS specific fil
From: |
Jes Sorensen |
Subject: |
[Qemu-devel] Re: [PATCH 5/9] Move qemu_gettimeofday() to OS specific files |
Date: |
Mon, 18 Oct 2010 10:08:27 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100921 Fedora/3.1.4-1.fc13 Lightning/1.0b3pre Thunderbird/3.1.4 |
On 10/16/10 21:32, Blue Swirl wrote:
> On Sat, Oct 16, 2010 at 4:04 PM, <address@hidden> wrote:
>> From: Jes Sorensen <address@hidden>
>>
>> In addition add sysemu.h includes to file requiring a prototype for
>> ffs()
>
> There are probably a lot more files which would need that:
> /src/qemu/hw/sd.c: In function 'sd_normal_command':
> /src/qemu/hw/sd.c:738:13: error: implicit declaration of function
> 'ffs' [-Werror=implicit-function-declaration]
> /src/qemu/hw/max7310.c: In function 'max7310_tx':
> /src/qemu/hw/max7310.c:94:13: error: implicit declaration of function
> 'ffs' [-Werror=implicit-function-declaration]
> /src/qemu/hw/unin_pci.c: In function 'unin_get_config_reg':
> /src/qemu/hw/unin_pci.c:101:9: error: implicit declaration of function
> 'ffs' [-Werror=implicit-function-declaration]
>
> Perhaps the prototype should be added someplace else.
I guess we'll have to bite the bullet. I don't really like it, but I
moved it to qemu-common.h to be consistent with the POSIX code. POSIX
relies on ffs() to be provided by strings.h which we include in
qemu-common.h
Should build (I hope) in the next patch. I tried building arm-softmmu
here but it wouldn't build for me at all due to other things so I
couldn't test it.
Cheers,
Jes
- [Qemu-devel] [PATCH v2 0/9] Re-factor osdep code + macro and brace fixes, Jes . Sorensen, 2010/10/16
- [Qemu-devel] [PATCH 2/9] Move osdep socket code to oslib-{posix, win32}.c, Jes . Sorensen, 2010/10/16
- [Qemu-devel] [PATCH 1/9] Move QEMU OS dependant library functions to OS specific files, Jes . Sorensen, 2010/10/16
- [Qemu-devel] [PATCH 4/9] We only support eventfd under POSIX, move qemu_eventfd() to os-posix.c, Jes . Sorensen, 2010/10/16
- [Qemu-devel] [PATCH 3/9] qemu_pipe() is used only by POSIX code, so move to oslib-posix.c, Jes . Sorensen, 2010/10/16
- [Qemu-devel] [PATCH 6/9] Do not redefine reserved key-words TRUE/FALSE, Jes . Sorensen, 2010/10/16
- [Qemu-devel] [PATCH 5/9] Move qemu_gettimeofday() to OS specific files, Jes . Sorensen, 2010/10/16
- [Qemu-devel] [PATCH 7/9] Separate qemu_pidfile() into OS specific versions, Jes . Sorensen, 2010/10/16
- [Qemu-devel] [PATCH 9/9] Remove unncessary includes, Jes . Sorensen, 2010/10/16
- [Qemu-devel] [PATCH 8/9] Consolidate oom_check() functions, Jes . Sorensen, 2010/10/16