[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI vendor id and
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM |
Date: |
Tue, 19 Oct 2010 23:25:36 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Oct 19, 2010 at 04:22:23PM -0500, Anthony Liguori wrote:
> On 10/19/2010 04:15 PM, Stefan Weil wrote:
> >Am 19.10.2010 10:37, schrieb Michael S. Tsirkin:
> >>On Mon, Oct 18, 2010 at 09:11:55PM +0200, Stefan Weil wrote:
> >>>QEMU must only make sure that patching of the supported roms
> >>>with supported devices work.
> >>
> >>I think that's what Anthony was saying too - make this depend
> >>on a qdev property and set it only in eepro100 for now.
> >>
> >
> >My new patch v3 implements something similar and does not need
> >a new qdev property:
>
> I prefer to have an explicit property in case a user actually wants
> to use this functionality. That said, if Michael's happy with the
> approach, I'm okay with it too.
>
> Regards,
>
> Anthony Liguori
I currently feel kind of the same, just to make this explicit ...
if you like, let me sleep on it.
> >Don't patch because the rom file was defined by the user:
> >
> >qemu -L pc-bios -boot n -netdev user,id=internet \
> > -device i82801,netdev=internet,romfile=gpxe-eepro100-80861209.rom
> >
> >Patch because we work with the built-in default rom file:
> >
> >qemu -L pc-bios -boot n -netdev user,id=internet \
> > -device i82801,netdev=internet
> >
> >This is a safe solution which respects user's rom data
> >without adding much more complexity.
> >
> >Regards,
> >Stefan
> >
- Re: [Qemu-devel] Re: [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM, (continued)
- Re: [Qemu-devel] Re: [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM, Anthony Liguori, 2010/10/18
- Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM, Anthony Liguori, 2010/10/18
- Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM, Anthony Liguori, 2010/10/18
- Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM, Stefan Weil, 2010/10/18
- Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM, Michael S. Tsirkin, 2010/10/19
- Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM, Stefan Weil, 2010/10/19
- Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM, Anthony Liguori, 2010/10/19
- Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM,
Michael S. Tsirkin <=
- [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM, Stefan Weil, 2010/10/19
- [Qemu-devel] Re: [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM, Gerd Hoffmann, 2010/10/20
- [Qemu-devel] Re: [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM, Stefan Weil, 2010/10/20
- [Qemu-devel] [PATCH 2/2] eepro100: Use a single rom file for all i825xx devices, Stefan Weil, 2010/10/15
- [Qemu-devel] Re: Where's gpxe-eepro100-80862449.rom ?, Stefan Weil, 2010/10/15
- [Qemu-devel] Re: Where's gpxe-eepro100-80862449.rom ?, Markus Armbruster, 2010/10/25
- [Qemu-devel] Re: Where's gpxe-eepro100-80862449.rom ?, Stefan Weil, 2010/10/25
- [Qemu-devel] Re: Where's gpxe-eepro100-80862449.rom ?, Michael S. Tsirkin, 2010/10/25