[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH v5 00/14] pcie port switch emulators
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] Re: [PATCH v5 00/14] pcie port switch emulators |
Date: |
Wed, 20 Oct 2010 01:02:13 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Oct 20, 2010 at 07:55:56AM +0900, Isaku Yamahata wrote:
> On Wed, Oct 20, 2010 at 12:40:49AM +0200, Michael S. Tsirkin wrote:
>
> > I think I suggested once a good way to implement this:
> >
> > - always make the bits w1c
> > - after config write:
> > if MHR is enabled, and you see that error log is not empty and that bit
> > is 0,
> > this means that someone has written 1b.
> > so pop the first error from the log, and set bit to 1 if it's not empty.
> >
> > This way we only touch w1c mask on setup, no tricky range checks.
> > Anything wrong with this approach?
>
> Basically okay.
> Without the range checks, we need to restore the old value to the register
> if 1b isn't written to the bit of the first error.
> Probably you prefer restoring it mostly always than the range check.
Well that would be consistent with how we handle config cycles
in the rest of the code. We had a lot of tricky range checking code
and we killed it all in favor of making operations idempotent so
they are safe to redo on each config cycle.
--
MST
- [Qemu-devel] [PATCH v5 11/14] x3130: pcie upstream port, (continued)
- [Qemu-devel] [PATCH v5 11/14] x3130: pcie upstream port, Isaku Yamahata, 2010/10/19
- [Qemu-devel] [PATCH v5 09/14] pcie port: define struct PCIEPort/PCIESlot and helper functions, Isaku Yamahata, 2010/10/19
- [Qemu-devel] [PATCH v5 05/14] msi: implements msi, Isaku Yamahata, 2010/10/19
- [Qemu-devel] [PATCH v5 10/14] ioh3420: pcie root port in X58 ioh, Isaku Yamahata, 2010/10/19
- [Qemu-devel] Re: [PATCH v5 00/14] pcie port switch emulators, Michael S. Tsirkin, 2010/10/19
[Qemu-devel] Re: [PATCH v5 00/14] pcie port switch emulators, Michael S. Tsirkin, 2010/10/19
[Qemu-devel] Re: [PATCH v5 00/14] pcie port switch emulators, Michael S. Tsirkin, 2010/10/19