[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [SeaBIOS] [PATCH] mark irq9 active high in DSDT

From: Avi Kivity
Subject: [Qemu-devel] Re: [SeaBIOS] [PATCH] mark irq9 active high in DSDT
Date: Thu, 21 Oct 2010 12:07:17 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100921 Fedora/3.1.4-1.fc13 Lightning/1.0b3pre Thunderbird/3.1.4

 On 10/21/2010 04:00 AM, Kevin O'Connor wrote:
On Wed, Oct 20, 2010 at 11:34:41AM +0200, Gleb Natapov wrote:
>  In PIIX4 SCI (irq9) is active high. Seabios marks it so in interrupt
>  override table, but some OSes (FreeBSD) require the same information to
>  be present in DSDT too. Make it so.
>  Signed-off-by: Gleb Natapov<address@hidden>


How do we manage the stable series wrt this issue?

qemu-kvm-0.12.5 has a regression within the stable series that this patch fixes. qemu 0.12.5 does not, but only because it does not emulate polarity in the I/O APIC correctly.

There are several paths we could take:

- do nothing, bug is fixed in mainline
- release a seabios 0.x.1 for qemu 0.13.1 with this patch
- same, plus seabios 0.y.1 for qemu 0.12.6 with this patch
- skip qemu (which is not truly affected), patch qemu-kvm's copy of seabios for both 0.12.z and 0.13.z

The third option is the most "correct" from a release engineering point of view, but involves more work for everyone. The fourth is quick pain relief but is a little forky.

error compiling committee.c: too many arguments to function

reply via email to

[Prev in Thread] Current Thread [Next in Thread]