Re: [Qemu-devel] [PATCH 1/2] Keep track of ISA ports ISA device is using in qdev.

[Markus Armbruster]

Gleb Natapov <address@hidden> writes:

> Prevent two devices from claiming the same io port.

Really?

Your new check for double-claim is in the new isa_init_ioport(), which
is for ISADevice only.  Thus, only qdevified ISA devices can opt for
this protection, by calling isa_init_ioport().  It doesn't protect from
devices who don't or can't opt in, such as PCI devices.

Anyway, we already check for double-claim in
register_ioport_{read,write}().  The check has issues --- hw_error() is
wrong there for hot plug.  But it's where the check should be, isn't it?